diff --git a/FlatCAMApp.py b/FlatCAMApp.py
index 79775a18..8cbbc58c 100644
--- a/FlatCAMApp.py
+++ b/FlatCAMApp.py
@@ -1368,26 +1368,6 @@ class App(QtCore.QObject):
self.ui.popmenu_new_exc.triggered.connect(self.new_excellon_object)
self.ui.popmenu_new_prj.triggered.connect(self.on_file_new)
- # Geometry Editor
- self.ui.draw_line.triggered.connect(self.geo_editor.draw_tool_path)
- self.ui.draw_rect.triggered.connect(self.geo_editor.draw_tool_rectangle)
- self.ui.draw_cut.triggered.connect(self.geo_editor.cutpath)
- self.ui.draw_move.triggered.connect(self.geo_editor.on_move)
-
- # Gerber Editor
- self.ui.grb_draw_pad.triggered.connect(self.grb_editor.on_pad_add)
- self.ui.grb_draw_pad_array.triggered.connect(self.grb_editor.on_pad_add_array)
- self.ui.grb_draw_track.triggered.connect(self.grb_editor.on_track_add)
- self.ui.grb_draw_region.triggered.connect(self.grb_editor.on_region_add)
- self.ui.grb_copy.triggered.connect(self.grb_editor.on_copy_button)
- self.ui.grb_delete.triggered.connect(self.grb_editor.on_delete_btn)
- self.ui.grb_move.triggered.connect(self.grb_editor.on_move_button)
-
- # Excellon Editor
- self.ui.drill.triggered.connect(self.exc_editor.exc_add_drill)
- self.ui.drill_array.triggered.connect(self.exc_editor.exc_add_drill_array)
- self.ui.drill_copy.triggered.connect(self.exc_editor.exc_copy_drills)
-
self.ui.zoomfit.triggered.connect(self.on_zoom_fit)
self.ui.clearplot.triggered.connect(self.clear_plots)
self.ui.replot.triggered.connect(self.plot_all)
@@ -2918,6 +2898,14 @@ class App(QtCore.QObject):
grb_obj.follow = False
grb_obj.apertures = {}
+ try:
+ grb_obj.options['xmin'] = 0
+ grb_obj.options['ymin'] = 0
+ grb_obj.options['xmax'] = 0
+ grb_obj.options['ymax'] = 0
+ except KeyError:
+ pass
+
self.new_object('gerber', 'new_grb', initialize, plot=False)
def on_object_created(self, obj, plot, autoselect):
@@ -4971,8 +4959,8 @@ class App(QtCore.QObject):
self.ui.cmenu_gridmenu.addSeparator()
grid_add = self.ui.cmenu_gridmenu.addAction(QtGui.QIcon('share/plus32.png'), "Add")
- grid_add.triggered.connect(self.on_grid_add)
grid_delete = self.ui.cmenu_gridmenu.addAction(QtGui.QIcon('share/delete32.png'), "Delete")
+ grid_add.triggered.connect(self.on_grid_add)
grid_delete.triggered.connect(self.on_grid_delete)
def set_grid(self):
diff --git a/README.md b/README.md
index d4006a3b..d5486bab 100644
--- a/README.md
+++ b/README.md
@@ -13,6 +13,8 @@ CAD program, and create G-Code for Isolation routing.
- small changes in GUI; optimized contextual menu display
- made sure that the Project Tab is disabled while one of the Editors is active and it is restored after returning to app
+- fixed some bugs recently introduced in Editors due of the changes done to the way mouse panning is detected
+- cleaned up the context menu's when in Editors; made some structural changes
25.04.2019
diff --git a/flatcamEditors/FlatCAMExcEditor.py b/flatcamEditors/FlatCAMExcEditor.py
index caa62102..7afa56b4 100644
--- a/flatcamEditors/FlatCAMExcEditor.py
+++ b/flatcamEditors/FlatCAMExcEditor.py
@@ -1646,6 +1646,13 @@ class FlatCAMExcEditor(QtCore.QObject):
if self.app.ui.grid_snap_btn.isChecked() is False:
self.app.ui.grid_snap_btn.trigger()
+ self.app.ui.popmenu_disable.setVisible(False)
+ self.app.ui.cmenu_newmenu.menuAction().setVisible(False)
+ self.app.ui.popmenu_properties.setVisible(False)
+ self.app.ui.e_editor_cmenu.menuAction().setVisible(True)
+ self.app.ui.g_editor_cmenu.menuAction().setVisible(False)
+ self.app.ui.grb_editor_cmenu.menuAction().setVisible(False)
+
# Tell the App that the editor is active
self.editor_active = True
@@ -1711,8 +1718,12 @@ class FlatCAMExcEditor(QtCore.QObject):
self.app.ui.update_obj_btn.setEnabled(False)
- self.app.ui.g_editor_cmenu.setEnabled(False)
- self.app.ui.e_editor_cmenu.setEnabled(False)
+ self.app.ui.popmenu_disable.setVisible(True)
+ self.app.ui.cmenu_newmenu.menuAction().setVisible(True)
+ self.app.ui.popmenu_properties.setVisible(True)
+ self.app.ui.g_editor_cmenu.menuAction().setVisible(False)
+ self.app.ui.e_editor_cmenu.menuAction().setVisible(False)
+ self.app.ui.grb_editor_cmenu.menuAction().setVisible(False)
# Show original geometry
if self.exc_obj:
@@ -1738,6 +1749,18 @@ class FlatCAMExcEditor(QtCore.QObject):
self.app.plotcanvas.vis_disconnect('mouse_double_click', self.app.on_double_click_over_plot)
self.app.collection.view.clicked.disconnect()
+ self.app.ui.popmenu_copy.triggered.disconnect()
+ self.app.ui.popmenu_delete.triggered.disconnect()
+ self.app.ui.popmenu_move.triggered.disconnect()
+
+ self.app.ui.popmenu_copy.triggered.connect(self.exc_copy_drills)
+ self.app.ui.popmenu_delete.triggered.connect(self.on_delete_btn)
+ self.app.ui.popmenu_move.triggered.connect(self.exc_move_drills)
+
+ # Excellon Editor
+ self.app.ui.drill.triggered.connect(self.exc_add_drill)
+ self.app.ui.drill_array.triggered.connect(self.exc_add_drill_array)
+
def disconnect_canvas_event_handlers(self):
# we restore the key and mouse control to FlatCAMApp method
# first connect to new, then disconnect the old handlers
@@ -1752,6 +1775,36 @@ class FlatCAMExcEditor(QtCore.QObject):
self.canvas.vis_disconnect('mouse_move', self.on_canvas_move)
self.canvas.vis_disconnect('mouse_release', self.on_exc_click_release)
+ try:
+ self.app.ui.popmenu_copy.triggered.disconnect(self.exc_copy_drills)
+ except TypeError:
+ pass
+
+ try:
+ self.app.ui.popmenu_delete.triggered.disconnect(self.on_delete_btn)
+ except TypeError:
+ pass
+
+ try:
+ self.app.ui.popmenu_move.triggered.disconnect(self.exc_move_drills)
+ except TypeError:
+ pass
+
+ self.app.ui.popmenu_copy.triggered.connect(self.app.on_copy_object)
+ self.app.ui.popmenu_delete.triggered.connect(self.app.on_delete)
+ self.app.ui.popmenu_move.triggered.connect(self.app.obj_move)
+
+ # Excellon Editor
+ try:
+ self.app.ui.drill.triggered.disconnect(self.exc_add_drill)
+ except TypeError:
+ pass
+
+ try:
+ self.app.ui.drill_array.triggered.disconnect(self.exc_add_drill_array)
+ except TypeError:
+ pass
+
def clear(self):
self.active_tool = None
# self.shape_buffer = []
@@ -2209,6 +2262,7 @@ class FlatCAMExcEditor(QtCore.QObject):
self.app.panning_action = False
else:
self.app.cursor = QtGui.QCursor()
+ self.app.populate_cmenu_grids()
self.app.ui.popMenu.popup(self.app.cursor.pos())
except Exception as e:
log.warning("Error: %s" % str(e))
@@ -2592,21 +2646,21 @@ class FlatCAMExcEditor(QtCore.QObject):
self.linear_angle_label.hide()
def exc_add_drill(self):
- self.select_tool('add')
+ self.select_tool('drill_add')
return
def exc_add_drill_array(self):
- self.select_tool('add_array')
+ self.select_tool('drill_array')
return
def exc_resize_drills(self):
- self.select_tool('resize')
+ self.select_tool('drill_resize')
return
def exc_copy_drills(self):
- self.select_tool('copy')
+ self.select_tool('drill_copy')
return
def exc_move_drills(self):
- self.select_tool('move')
+ self.select_tool('drill_move')
return
\ No newline at end of file
diff --git a/flatcamEditors/FlatCAMGeoEditor.py b/flatcamEditors/FlatCAMGeoEditor.py
index 17b7c6c8..c848e096 100644
--- a/flatcamEditors/FlatCAMGeoEditor.py
+++ b/flatcamEditors/FlatCAMGeoEditor.py
@@ -2970,6 +2970,11 @@ class FlatCAMGeoEditor(QtCore.QObject):
self.app.ui.snap_toolbar.setDisabled(False)
+ self.app.ui.popmenu_disable.setVisible(False)
+ self.app.ui.cmenu_newmenu.menuAction().setVisible(False)
+ self.app.ui.popmenu_properties.setVisible(False)
+ self.app.ui.g_editor_cmenu.menuAction().setVisible(True)
+
# prevent the user to change anything in the Selected Tab while the Geo Editor is active
sel_tab_widget_list = self.app.ui.selected_tab.findChildren(QtWidgets.QWidget)
for w in sel_tab_widget_list:
@@ -3038,6 +3043,13 @@ class FlatCAMGeoEditor(QtCore.QObject):
# Tell the app that the editor is no longer active
self.editor_active = False
+ self.app.ui.popmenu_disable.setVisible(True)
+ self.app.ui.cmenu_newmenu.menuAction().setVisible(True)
+ self.app.ui.popmenu_properties.setVisible(True)
+ self.app.ui.grb_editor_cmenu.menuAction().setVisible(False)
+ self.app.ui.e_editor_cmenu.menuAction().setVisible(False)
+ self.app.ui.g_editor_cmenu.menuAction().setVisible(False)
+
try:
# re-enable all the widgets in the Selected Tab that were disabled after entering in Edit Geometry Mode
sel_tab_widget_list = self.app.ui.selected_tab.findChildren(QtWidgets.QWidget)
@@ -3066,7 +3078,21 @@ class FlatCAMGeoEditor(QtCore.QObject):
self.app.plotcanvas.vis_disconnect('mouse_release', self.app.on_mouse_click_release_over_plot)
self.app.plotcanvas.vis_disconnect('mouse_double_click', self.app.on_double_click_over_plot)
- self.app.collection.view.clicked.disconnect()
+ # self.app.collection.view.clicked.disconnect()
+ self.app.ui.popmenu_copy.triggered.disconnect()
+ self.app.ui.popmenu_delete.triggered.disconnect()
+ self.app.ui.popmenu_move.triggered.disconnect()
+
+ self.app.ui.popmenu_copy.triggered.connect(lambda: self.select_tool('copy'))
+ self.app.ui.popmenu_delete.triggered.connect(self.on_delete_btn)
+ self.app.ui.popmenu_move.triggered.connect(lambda: self.select_tool('move'))
+
+ # Geometry Editor
+ self.app.ui.draw_line.triggered.connect(self.draw_tool_path)
+ self.app.ui.draw_rect.triggered.connect(self.draw_tool_rectangle)
+ self.app.ui.draw_cut.triggered.connect(self.cutpath)
+ self.app.ui.draw_move.triggered.connect(self.on_move)
+
def disconnect_canvas_event_handlers(self):
# we restore the key and mouse control to FlatCAMApp method
@@ -3076,12 +3102,50 @@ class FlatCAMGeoEditor(QtCore.QObject):
self.app.plotcanvas.vis_connect('mouse_move', self.app.on_mouse_move_over_plot)
self.app.plotcanvas.vis_connect('mouse_release', self.app.on_mouse_click_release_over_plot)
self.app.plotcanvas.vis_connect('mouse_double_click', self.app.on_double_click_over_plot)
- self.app.collection.view.clicked.connect(self.app.collection.on_mouse_down)
+ # self.app.collection.view.clicked.connect(self.app.collection.on_mouse_down)
self.canvas.vis_disconnect('mouse_press', self.on_canvas_click)
self.canvas.vis_disconnect('mouse_move', self.on_canvas_move)
self.canvas.vis_disconnect('mouse_release', self.on_geo_click_release)
+ try:
+ self.app.ui.popmenu_copy.triggered.disconnect(lambda: self.select_tool('copy'))
+ except TypeError:
+ pass
+ try:
+ self.app.ui.popmenu_delete.triggered.disconnect(self.on_delete_btn)
+ except TypeError:
+ pass
+ try:
+ self.app.ui.popmenu_move.triggered.disconnect(lambda: self.select_tool('move'))
+ except TypeError:
+ pass
+
+ self.app.ui.popmenu_copy.triggered.connect(self.app.on_copy_object)
+ self.app.ui.popmenu_delete.triggered.connect(self.app.on_delete)
+ self.app.ui.popmenu_move.triggered.connect(self.app.obj_move)
+
+ # Geometry Editor
+ try:
+ self.app.ui.draw_line.triggered.disconnect(self.draw_tool_path)
+ except TypeError:
+ pass
+
+ try:
+ self.app.ui.draw_rect.triggered.disconnect(self.draw_tool_rectangle)
+ except TypeError:
+ pass
+
+ try:
+ self.app.ui.draw_cut.triggered.disconnect(self.cutpath)
+ except TypeError:
+ pass
+
+ try:
+ self.app.ui.draw_move.triggered.disconnect(self.on_move)
+ except TypeError:
+ pass
+
def add_shape(self, shape):
"""
Adds a shape to the shape storage.
@@ -3248,15 +3312,20 @@ class FlatCAMGeoEditor(QtCore.QObject):
:return: None
"""
+ self.pos = self.canvas.vispy_canvas.translate_coords(event.pos)
+
+ if self.app.grid_status():
+ self.pos = self.app.geo_editor.snap(self.pos[0], self.pos[1])
+ self.app.app_cursor.enabled = True
+ # Update cursor
+ self.app.app_cursor.set_data(np.asarray([(self.pos[0], self.pos[1])]), symbol='++', edge_color='black',
+ size=20)
+ else:
+ self.app.app_cursor.enabled = False
+
if event.button is 1:
self.app.ui.rel_position_label.setText("Dx: %.4f Dy: "
"%.4f " % (0, 0))
- self.pos = self.canvas.vispy_canvas.translate_coords(event.pos)
-
- ### Snap coordinates
- x, y = self.snap(self.pos[0], self.pos[1])
-
- self.pos = (x, y)
modifiers = QtWidgets.QApplication.keyboardModifiers()
# If the SHIFT key is pressed when LMB is clicked then the coordinates are copied to clipboard
@@ -3314,16 +3383,12 @@ class FlatCAMGeoEditor(QtCore.QObject):
self.x = event.xdata
self.y = event.ydata
- # Prevent updates on pan
- # if len(event.buttons) > 0:
- # return
+ self.app.ui.popMenu.mouse_is_panning = False
# if the RMB is clicked and mouse is moving over plot then 'panning_action' is True
- if event.button == 2:
- self.app.panning_action = True
+ if event.button == 2 and event.is_dragging == 1:
+ self.app.ui.popMenu.mouse_is_panning = True
return
- else:
- self.app.panning_action = False
try:
x = float(event.xdata)
@@ -3335,7 +3400,13 @@ class FlatCAMGeoEditor(QtCore.QObject):
return
### Snap coordinates
- x, y = self.snap(x, y)
+ if self.app.grid_status():
+ x, y = self.snap(x, y)
+ self.app.app_cursor.enabled = True
+ # Update cursor
+ self.app.app_cursor.set_data(np.asarray([(x, y)]), symbol='++', edge_color='black', size=20)
+ else:
+ self.app.app_cursor.enabled = False
self.snap_x = x
self.snap_y = y
@@ -3376,9 +3447,6 @@ class FlatCAMGeoEditor(QtCore.QObject):
else:
self.app.selection_type = None
- # Update cursor
- self.app.app_cursor.set_data(np.asarray([(x, y)]), symbol='++', edge_color='black', size=20)
-
def on_geo_click_release(self, event):
pos_canvas = self.canvas.vispy_canvas.translate_coords(event.pos)
@@ -3391,11 +3459,15 @@ class FlatCAMGeoEditor(QtCore.QObject):
# canvas menu
try:
if event.button == 2: # right click
- if self.app.panning_action is True:
- self.app.panning_action = False
- else:
+ if self.app.ui.popMenu.mouse_is_panning is False:
if self.in_action is False:
+ try:
+ QtGui.QGuiApplication.restoreOverrideCursor()
+ except:
+ pass
+
self.app.cursor = QtGui.QCursor()
+ self.app.populate_cmenu_grids()
self.app.ui.popMenu.popup(self.app.cursor.pos())
else:
# if right click on canvas and the active tool need to be finished (like Path or Polygon)
diff --git a/flatcamEditors/FlatCAMGrbEditor.py b/flatcamEditors/FlatCAMGrbEditor.py
index 18c3dac0..90d02079 100644
--- a/flatcamEditors/FlatCAMGrbEditor.py
+++ b/flatcamEditors/FlatCAMGrbEditor.py
@@ -2686,6 +2686,11 @@ class FlatCAMGrbEditor(QtCore.QObject):
self.app.ui.popmenu_edit.setVisible(False)
self.app.ui.popmenu_save.setVisible(True)
+ self.app.ui.popmenu_disable.setVisible(False)
+ self.app.ui.cmenu_newmenu.menuAction().setVisible(False)
+ self.app.ui.popmenu_properties.setVisible(False)
+ self.app.ui.grb_editor_cmenu.menuAction().setVisible(True)
+
# Tell the App that the editor is active
self.editor_active = True
@@ -2748,14 +2753,17 @@ class FlatCAMGrbEditor(QtCore.QObject):
self.app.ui.update_obj_btn.setEnabled(False)
- self.app.ui.g_editor_cmenu.setEnabled(False)
- self.app.ui.grb_editor_cmenu.setEnabled(False)
- self.app.ui.e_editor_cmenu.setEnabled(False)
-
# adjust the visibility of some of the canvas context menu
self.app.ui.popmenu_edit.setVisible(True)
self.app.ui.popmenu_save.setVisible(False)
+ self.app.ui.popmenu_disable.setVisible(True)
+ self.app.ui.cmenu_newmenu.menuAction().setVisible(True)
+ self.app.ui.popmenu_properties.setVisible(True)
+ self.app.ui.g_editor_cmenu.menuAction().setVisible(False)
+ self.app.ui.e_editor_cmenu.menuAction().setVisible(False)
+ self.app.ui.grb_editor_cmenu.menuAction().setVisible(False)
+
# Show original geometry
if self.gerber_obj:
self.gerber_obj.visible = True
@@ -2778,6 +2786,20 @@ class FlatCAMGrbEditor(QtCore.QObject):
self.canvas.vis_disconnect('mouse_double_click', self.app.on_double_click_over_plot)
self.app.collection.view.clicked.disconnect()
+ self.app.ui.popmenu_copy.triggered.disconnect()
+ self.app.ui.popmenu_delete.triggered.disconnect()
+ self.app.ui.popmenu_move.triggered.disconnect()
+
+ self.app.ui.popmenu_copy.triggered.connect(self.on_copy_button)
+ self.app.ui.popmenu_delete.triggered.connect(self.on_delete_btn)
+ self.app.ui.popmenu_move.triggered.connect(self.on_move_button)
+
+ # Gerber Editor
+ self.app.ui.grb_draw_pad.triggered.connect(self.on_pad_add)
+ self.app.ui.grb_draw_pad_array.triggered.connect(self.on_pad_add_array)
+ self.app.ui.grb_draw_track.triggered.connect(self.on_track_add)
+ self.app.ui.grb_draw_region.triggered.connect(self.on_region_add)
+
def disconnect_canvas_event_handlers(self):
# we restore the key and mouse control to FlatCAMApp method
@@ -2793,6 +2815,47 @@ class FlatCAMGrbEditor(QtCore.QObject):
self.canvas.vis_disconnect('mouse_move', self.on_canvas_move)
self.canvas.vis_disconnect('mouse_release', self.on_grb_click_release)
+ try:
+ self.app.ui.popmenu_copy.triggered.disconnect(self.on_copy_button)
+ except TypeError:
+ pass
+
+ try:
+ self.app.ui.popmenu_delete.triggered.disconnect(self.on_delete_btn)
+ except TypeError:
+ pass
+
+ try:
+ self.app.ui.popmenu_move.triggered.disconnect(self.on_move_button)
+ except TypeError:
+ pass
+
+ self.app.ui.popmenu_copy.triggered.connect(self.app.on_copy_object)
+ self.app.ui.popmenu_delete.triggered.connect(self.app.on_delete)
+ self.app.ui.popmenu_move.triggered.connect(self.app.obj_move)
+
+ # Gerber Editor
+
+ try:
+ self.app.ui.grb_draw_pad.triggered.disconnect(self.on_pad_add)
+ except TypeError:
+ pass
+
+ try:
+ self.app.ui.grb_draw_pad_array.triggered.disconnect(self.on_pad_add_array)
+ except TypeError:
+ pass
+
+ try:
+ self.app.ui.grb_draw_track.triggered.disconnect(self.on_track_add)
+ except TypeError:
+ pass
+
+ try:
+ self.app.ui.grb_draw_region.triggered.disconnect(self.on_region_add)
+ except TypeError:
+ pass
+
def clear(self):
self.active_tool = None
# self.shape_buffer = []
@@ -3173,15 +3236,21 @@ class FlatCAMGrbEditor(QtCore.QObject):
:return: None
"""
+ self.pos = self.canvas.vispy_canvas.translate_coords(event.pos)
+
+ if self.app.grid_status():
+ self.pos = self.app.geo_editor.snap(self.pos[0], self.pos[1])
+ self.app.app_cursor.enabled = True
+ # Update cursor
+ self.app.app_cursor.set_data(np.asarray([(self.pos[0], self.pos[1])]), symbol='++', edge_color='black',
+ size=20)
+ else:
+ self.app.app_cursor.enabled = False
+
+
if event.button is 1:
self.app.ui.rel_position_label.setText("Dx: %.4f Dy: "
"%.4f " % (0, 0))
- self.pos = self.canvas.vispy_canvas.translate_coords(event.pos)
-
- ### Snap coordinates
- x, y = self.app.geo_editor.snap(self.pos[0], self.pos[1])
-
- self.pos = (x, y)
# Selection with left mouse button
if self.active_tool is not None and event.button is 1:
@@ -3220,10 +3289,9 @@ class FlatCAMGrbEditor(QtCore.QObject):
self.app.log.debug("No active tool to respond to click!")
def on_grb_click_release(self, event):
- pos_canvas = self.canvas.vispy_canvas.translate_coords(event.pos)
-
self.modifiers = QtWidgets.QApplication.keyboardModifiers()
+ pos_canvas = self.canvas.vispy_canvas.translate_coords(event.pos)
if self.app.grid_status():
pos = self.app.geo_editor.snap(pos_canvas[0], pos_canvas[1])
else:
@@ -3233,9 +3301,7 @@ class FlatCAMGrbEditor(QtCore.QObject):
# canvas menu
try:
if event.button == 2: # right click
- if self.app.panning_action is True:
- self.app.panning_action = False
- else:
+ if self.app.ui.popMenu.mouse_is_panning is False:
if self.in_action is False:
try:
QtGui.QGuiApplication.restoreOverrideCursor()
@@ -3250,6 +3316,7 @@ class FlatCAMGrbEditor(QtCore.QObject):
self.select_tool('select')
else:
self.app.cursor = QtGui.QCursor()
+ self.app.populate_cmenu_grids()
self.app.ui.popMenu.popup(self.app.cursor.pos())
else:
# if right click on canvas and the active tool need to be finished (like Path or Polygon)
@@ -3356,22 +3423,18 @@ class FlatCAMGrbEditor(QtCore.QObject):
:return: None
"""
- pos = self.canvas.vispy_canvas.translate_coords(event.pos)
- event.xdata, event.ydata = pos[0], pos[1]
+ pos_canvas = self.canvas.vispy_canvas.translate_coords(event.pos)
+ event.xdata, event.ydata = pos_canvas[0], pos_canvas[1]
self.x = event.xdata
self.y = event.ydata
- # Prevent updates on pan
- # if len(event.buttons) > 0:
- # return
+ self.app.ui.popMenu.mouse_is_panning = False
# if the RMB is clicked and mouse is moving over plot then 'panning_action' is True
- if event.button == 2:
- self.app.panning_action = True
+ if event.button == 2 and event.is_dragging == 1:
+ self.app.ui.popMenu.mouse_is_panning = True
return
- else:
- self.app.panning_action = False
try:
x = float(event.xdata)
@@ -3383,7 +3446,13 @@ class FlatCAMGrbEditor(QtCore.QObject):
return
### Snap coordinates
- x, y = self.app.geo_editor.app.geo_editor.snap(x, y)
+ if self.app.grid_status():
+ x, y = self.app.geo_editor.snap(x, y)
+ self.app.app_cursor.enabled = True
+ # Update cursor
+ self.app.app_cursor.set_data(np.asarray([(x, y)]), symbol='++', edge_color='black', size=20)
+ else:
+ self.app.app_cursor.enabled = False
self.snap_x = x
self.snap_y = y
@@ -3405,7 +3474,6 @@ class FlatCAMGrbEditor(QtCore.QObject):
geo = self.active_tool.utility_geometry(data=(x, y))
if isinstance(geo, DrawToolShape) and geo.geo is not None:
-
# Remove any previous utility shape
self.tool_shape.clear(update=True)
self.draw_utility_geometry(geo=geo)
@@ -3417,7 +3485,7 @@ class FlatCAMGrbEditor(QtCore.QObject):
if isinstance(self.active_tool, FCRegion) or isinstance(self.active_tool, FCTrack):
pass
else:
- dx = pos[0] - self.pos[0]
+ dx = pos_canvas[0] - self.pos[0]
self.app.delete_selection_shape()
if dx < 0:
self.app.draw_moving_selection_shape((self.pos[0], self.pos[1]), (x,y),
@@ -3430,9 +3498,6 @@ class FlatCAMGrbEditor(QtCore.QObject):
else:
self.app.selection_type = None
- # Update cursor
- self.app.app_cursor.set_data(np.asarray([(x, y)]), symbol='++', edge_color='black', size=20)
-
def on_canvas_key_release(self, event):
self.key = None
diff --git a/flatcamGUI/FlatCAMGUI.py b/flatcamGUI/FlatCAMGUI.py
index a1148665..695807e3 100644
--- a/flatcamGUI/FlatCAMGUI.py
+++ b/flatcamGUI/FlatCAMGUI.py
@@ -1592,15 +1592,10 @@ class FlatCAMGUI(QtWidgets.QMainWindow):
self.grb_draw_pad_array = self.grb_editor_cmenu.addAction(QtGui.QIcon('share/padarray32.png'), _("Pad Array"))
self.grb_draw_track = self.grb_editor_cmenu.addAction(QtGui.QIcon('share/track32.png'), _("Track"))
self.grb_draw_region = self.grb_editor_cmenu.addAction(QtGui.QIcon('share/polygon32.png'), _("Region"))
- self.grb_editor_cmenu.addSeparator()
- self.grb_copy = self.grb_editor_cmenu.addAction(QtGui.QIcon('share/copy.png'), _("Copy"))
- self.grb_delete = self.grb_editor_cmenu.addAction(QtGui.QIcon('share/trash32.png'), _("Delete"))
- self.grb_move = self.grb_editor_cmenu.addAction(QtGui.QIcon('share/move32.png'), _("Move"))
self.e_editor_cmenu = self.popMenu.addMenu(QtGui.QIcon('share/drill32.png'), _("Exc Editor"))
self.drill = self.e_editor_cmenu.addAction(QtGui.QIcon('share/drill32.png'), _("Add Drill"))
self.drill_array = self.e_editor_cmenu.addAction(QtGui.QIcon('share/addarray32.png'), _("Add Drill Array"))
- self.drill_copy = self.e_editor_cmenu.addAction(QtGui.QIcon('share/copy32.png'), _("Copy Drill(s)"))
self.popMenu.addSeparator()
self.popmenu_copy = self.popMenu.addAction(QtGui.QIcon('share/copy32.png'), _("Copy"))
@@ -1740,9 +1735,9 @@ class FlatCAMGUI(QtWidgets.QMainWindow):
# start with GRID activated
self.grid_snap_btn.trigger()
- self.g_editor_cmenu.setEnabled(False)
- self.grb_editor_cmenu.setEnabled(False)
- self.e_editor_cmenu.setEnabled(False)
+ self.g_editor_cmenu.menuAction().setVisible(False)
+ self.grb_editor_cmenu.menuAction().setVisible(False)
+ self.e_editor_cmenu.menuAction().setVisible(False)
self.general_defaults_form = GeneralPreferencesUI()
self.gerber_defaults_form = GerberPreferencesUI()