From 373e01310e4ece07e80a25eb0cc0ca798182cb6c Mon Sep 17 00:00:00 2001
From: bartool <bartoolina@gmail.com>
Date: Sun, 21 Sep 2025 22:01:46 +0200
Subject: [PATCH] refactor: update GPhotoCamera configuration methods for
 consistency

---
 core/camera/base_camera.py   | 19 +++++++++++++++++--
 core/camera/gphoto_camera.py |  4 ++--
 2 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/core/camera/base_camera.py b/core/camera/base_camera.py
index 8e0b9f2..8c2f5b1 100644
--- a/core/camera/base_camera.py
+++ b/core/camera/base_camera.py
@@ -1,5 +1,4 @@
 from abc import ABC, abstractmethod
-from PySide6.QtCore import Signal
 
 
 class BaseCamera(ABC):
@@ -17,6 +16,22 @@ class BaseCamera(ABC):
     @abstractmethod
     def get_frame(self):
         raise NotImplementedError
-    
+
+    @abstractmethod
+    def get_config_by_id(self, id: int) -> dict:
+        raise NotImplementedError
+
+    @abstractmethod
+    def get_config_by_name(self, name: str) -> dict:
+        raise NotImplementedError
+
+    @abstractmethod
+    def set_config_by_id(self, id: int, value: str):
+        raise NotImplementedError
+
+    @abstractmethod
+    def set_config_by_name(self, name: str, value: str):
+        raise NotImplementedError
+
     def get_error_msg(self):
         return str(self.error_msg)
diff --git a/core/camera/gphoto_camera.py b/core/camera/gphoto_camera.py
index bb925ac..adb2c22 100644
--- a/core/camera/gphoto_camera.py
+++ b/core/camera/gphoto_camera.py
@@ -88,10 +88,10 @@ class GPhotoCamera(BaseCamera):
 
         self.set_config(config, value)
 
-    def set_config_by_name(self, name: str):
+    def set_config_by_name(self, name: str, value: str):
         config = self.get_config_by_name(name)
 
-        self.set_config(config, name)
+        self.set_config(config, value)
 
     def _save_config(self, config):
         if not self.camera: