bartool/MayoStainHelper
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: initialize QTimer with parent and ensure proper thread cleanup on stop

Browse Source
This commit is contained in:
bartool
2025-10-13 19:36:09 +02:00
parent feebc5153a
commit 2c1233f304
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
core/camera/camera_controller.py
View File

@@ -23,7 +23,7 @@ class CameraWorker(QObject):
@Slot() @Slot()
def initialize_worker(self): def initialize_worker(self):
"""Initializes the timer in the worker's thread.""" """Initializes the timer in the worker's thread."""
self.timer = QTimer() self.timer = QTimer(self)
self.timer.timeout.connect(self._update_frame) self.timer.timeout.connect(self._update_frame)
@Slot(BaseCamera, int) @Slot(BaseCamera, int)
@@ -138,12 +138,15 @@ class CameraController(QObject):
# Initialize worker when thread starts # Initialize worker when thread starts
self._thread.started.connect(self._worker.initialize_worker) self._thread.started.connect(self._worker.initialize_worker)
self._thread.finished.connect(self._worker.stop_camera)
self._thread.start() self._thread.start()
def stop(self): def stop(self):
self._thread.quit() if self._thread.isRunning():
self._thread.wait() self._thread.quit()
self._thread.wait()
self._thread.deleteLater()
def set_camera(self, camera: BaseCamera, fps: int = 15) -> None: def set_camera(self, camera: BaseCamera, fps: int = 15) -> None:
self._set_camera_requested.emit(camera, fps) self._set_camera_requested.emit(camera, fps)